Support log correlation on App Engine standard 2nd gen #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dwsupplee
suggested changes
Nov 8, 2018
| $server['GOOGLE_CLOUD_PROJECT'], | ||
| $traceId | ||
| ); | ||
| } else { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@dwsupplee Thanks! PTAL |
dwsupplee
reviewed
Nov 8, 2018
| $this->assertEquals($versionId, $metadataProvider->versionId()); | ||
| $this->assertEquals($labels, $metadataProvider->labels()); | ||
| } | ||
| public function testData() |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dwsupplee
approved these changes
Nov 8, 2018
dwsupplee
reviewed
Nov 8, 2018
| $serviceId, | ||
| $versionId, | ||
| $labels | ||
| ) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dwsupplee
pushed a commit
that referenced
this pull request
Nov 8, 2018
* Revert "Support log correlation on App Engine standard 2nd gen (#1407)" This reverts commit 38457a8. * Revert "[CHANGE ME] Re-generated Speech to pick up changes in the API or client library generator. (#1410)" This reverts commit 91ea697. * Revert "[CHANGE ME] Re-generated Monitoring to pick up changes in the API or client library generator. (#1409)" This reverts commit c93d10f. * Revert "Comment update, add several helper methods (#1408)" This reverts commit f99201e.
Merged
MGDSoft
added a commit
to MGDSoft/stackdriver-bundle
that referenced
this pull request
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1277